Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Fix make all histories private with immutable histories #18200

Merged
merged 5 commits into from
May 22, 2024
Merged

[24.0] Fix make all histories private with immutable histories #18200

merged 5 commits into from
May 22, 2024

Conversation

davelopez
Copy link
Contributor

Fixes #18146

I'm still on the fence if archived histories should be altered, but I guess it is ok since the confirmation message now mentions it.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added this to the 24.0 milestone May 22, 2024
mvdbeek
mvdbeek approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvdbeek mvdbeek merged commit eef864a into galaxyproject:release_24.0 May 22, 2024
51 checks passed
@davelopez davelopez deleted the 24.0_fix_make_private_immutable branch May 22, 2024 15:13
@jdavcs jdavcs modified the milestones: 24.0, 24.1 May 23, 2024
@davelopez davelopez mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/backend kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @mvdbeek @jdavcs